Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manager/sbt): support more seq constructors #12541

Merged
merged 9 commits into from
Dec 10, 2021

Conversation

martijnhoekstra
Copy link
Contributor

@martijnhoekstra martijnhoekstra commented Nov 7, 2021

Changes:

Add List and Stream as alternative patterns for Seq for sbt

Context:

Renovate seems to only recognize Seqs created with Seq(...). Seqs created in other ways, like for example with List(...) or Stream(...) are not matched. This PR also matches those constructors.

That at least plugs some of the list options. There are infinitely many more, but hopefully they are less common. It's not entirely trivial to follow how the document is parsed exactly./

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

viceice
viceice previously approved these changes Nov 7, 2021
@viceice viceice changed the title add some more seq constructors for sbt fix(manager/sbt): support more seq constructors Nov 7, 2021
@viceice viceice added the manager:sbt SBT package manager label Nov 7, 2021
@rarkins rarkins enabled auto-merge (squash) November 7, 2021 13:42
@HonkingGoose
Copy link
Collaborator

Needs a lint-fix run. 😉

auto-merge was automatically disabled November 7, 2021 20:01

Head branch was pushed to by a user without write access

rarkins
rarkins previously approved these changes Nov 8, 2021
@rarkins rarkins enabled auto-merge (squash) November 8, 2021 07:29
@HonkingGoose
Copy link
Collaborator

And now the unit tests are failing. So there's more work to be done before this can be merged.

auto-merge was automatically disabled November 8, 2021 20:47

Head branch was pushed to by a user without write access

@martijnhoekstra
Copy link
Contributor Author

At this point, everything passes for me locally. Should have checked from the start, sorry about that!

@rarkins rarkins requested a review from zharinov December 8, 2021 12:25
@rarkins rarkins enabled auto-merge (squash) December 10, 2021 10:36
@rarkins rarkins merged commit bdbcd61 into renovatebot:main Dec 10, 2021
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 30.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
manager:sbt SBT package manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants